Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Admin API front-end #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use Admin API front-end #6

wants to merge 3 commits into from

Conversation

mirhmousavi
Copy link
Contributor

@mirhmousavi mirhmousavi commented May 3, 2024 •
edited
Loading

This is the front-end part of Admin API integration changes.

To make it easy to review I kept changes as minimum as possible

The back-end changes PR can be found https://github.com/surfly/nic-surfly-integration/pull/68

@mirhmousavi mirhmousavi changed the title Mir use admin api Use Admin API front-end May 7, 2024
@mirhmousavi mirhmousavi requested review from jsnjack and aogz May 7, 2024 12:08
jsnjack
jsnjack reviewed May 15, 2024
View reviewed changes
Copy link
Member

@jsnjack jsnjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the pr from my review list. Please re-request a review when the pending changes are addressed and everything is ready. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnjack jsnjack jsnjack approved these changes

@aogz aogz aogz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirhmousavi @jsnjack @aogz